Skip to content

Add clipToWorldBounds and converters between: frame, world, view and game #3419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: 6.2.0
Choose a base branch
from
Open

Add clipToWorldBounds and converters between: frame, world, view and game #3419

wants to merge 12 commits into from

Conversation

Geokureli
Copy link
Member

@Geokureli Geokureli commented Apr 17, 2025 •
edited
Loading

WIP

Closes #2301 and #2898

Adds various sprite.clipToWorldRect(someRect) and sprite.clipToViewRect(someRect) methods that adjust the sprites clipRect so that it matches the given world or view coordinate

To Do

  • Retry CI when stuff works
  • Find out why this fails on hardware="false"
  • Use different x/y values in tests. this would have caught the previous error
  • Make getPixelAt this work with sprite.color and colorTransform

@Geokureli Geokureli added this to the 6.2.0 milestone Apr 17, 2025
@Geokureli Geokureli changed the title Frame clip rect Add clipToWorldBounds and converters between: frame, world, view and game Apr 17, 2025
@Geokureli Geokureli mentioned this pull request Apr 17, 2025
Closed
@Geokureli Geokureli changed the base branch from dev to 6.2.0 April 28, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
New Feature Structure
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.

Oddities when using clipRect + scale.
1 participant
@Geokureli